Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Replace CONFIG_ARCH_HAVE_VFORK with CONFIG_ARCH_HAVE_FORK #1962

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

masayuki2009
Copy link
Contributor

@masayuki2009 masayuki2009 commented Aug 13, 2023

Summary

Impact

Testing

  • Successfully tested with rv-virt:smp64, spresense:smp, and sim:smp.

masayuki2009 added a commit to masayuki2009/incubator-nuttx that referenced this pull request Nov 16, 2023
Summary:
- Temporarily disables ARCH_HAVE_FORK for arm64 to address a crash issue,
  as detailed in apache#9755.
- This is a precautionary measure until a more permanent solution is implemented.

Impact:
- Temporarily limits certain functionalities on arm64,
  but necessary to ensure system stability.

Testing:
- Successfully tested on QEMU-8.1.2.
- Note: please apply the changes from apache/nuttx-apps#1962.

Signed-off-by: Masayuki Ishikawa <[email protected]>
Summary:

- Resolves an issue where `vfork_test` was not executed following
  the renaming from CONFIG_ARCH_HAVE_VFORK to CONFIG_ARCH_HAVE_FORK,
  as detailed in apache/nuttx#9755.

Impact:
- Please merge apache/nuttx#11200 before
  merging this PR.

Testing:
- Successfully tested with rv-virt:smp64, spresense:smp, and sim:smp.

Signed-off-by: Masayuki Ishikawa <[email protected]>
@masayuki2009
Copy link
Contributor Author

masayuki2009 commented Nov 16, 2023

Please ignore the following style issues.

Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/interpreters/bas/bas_statement.c:53:7: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/interpreters/bas/bas_statement.c:53:14: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/interpreters/bas/bas_statement.c:53:31: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/interpreters/bas/bas_statement.c:58:13: error: Mixed case identifier found
Error: /home/runner/work/nuttx-apps/nuttx-apps/apps/interpreters/bas/bas_statement.c:69:10: error: Mixed case identifier found
...

xiaoxiang781216 pushed a commit to apache/nuttx that referenced this pull request Nov 16, 2023
Summary:
- Temporarily disables ARCH_HAVE_FORK for arm64 to address a crash issue,
  as detailed in #9755.
- This is a precautionary measure until a more permanent solution is implemented.

Impact:
- Temporarily limits certain functionalities on arm64,
  but necessary to ensure system stability.

Testing:
- Successfully tested on QEMU-8.1.2.
- Note: please apply the changes from apache/nuttx-apps#1962.

Signed-off-by: Masayuki Ishikawa <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 79c7962 into apache:master Nov 16, 2023
24 of 25 checks passed
casaroli pushed a commit to casaroli/nuttx that referenced this pull request Jan 25, 2024
Summary:
- Temporarily disables ARCH_HAVE_FORK for arm64 to address a crash issue,
  as detailed in apache#9755.
- This is a precautionary measure until a more permanent solution is implemented.

Impact:
- Temporarily limits certain functionalities on arm64,
  but necessary to ensure system stability.

Testing:
- Successfully tested on QEMU-8.1.2.
- Note: please apply the changes from apache/nuttx-apps#1962.

Signed-off-by: Masayuki Ishikawa <[email protected]>
freakishness pushed a commit to freakishness/incubator-nuttx that referenced this pull request Feb 18, 2024
Summary:
- Temporarily disables ARCH_HAVE_FORK for arm64 to address a crash issue,
  as detailed in apache#9755.
- This is a precautionary measure until a more permanent solution is implemented.

Impact:
- Temporarily limits certain functionalities on arm64,
  but necessary to ensure system stability.

Testing:
- Successfully tested on QEMU-8.1.2.
- Note: please apply the changes from apache/nuttx-apps#1962.

Signed-off-by: Masayuki Ishikawa <[email protected]>
halyssonJr pushed a commit to halyssonJr/nuttx that referenced this pull request Apr 10, 2024
Summary:
- Temporarily disables ARCH_HAVE_FORK for arm64 to address a crash issue,
  as detailed in apache#9755.
- This is a precautionary measure until a more permanent solution is implemented.

Impact:
- Temporarily limits certain functionalities on arm64,
  but necessary to ensure system stability.

Testing:
- Successfully tested on QEMU-8.1.2.
- Note: please apply the changes from apache/nuttx-apps#1962.

Signed-off-by: Masayuki Ishikawa <[email protected]>
nealef pushed a commit to nealef/nuttx that referenced this pull request May 29, 2024
Summary:
- Temporarily disables ARCH_HAVE_FORK for arm64 to address a crash issue,
  as detailed in apache#9755.
- This is a precautionary measure until a more permanent solution is implemented.

Impact:
- Temporarily limits certain functionalities on arm64,
  but necessary to ensure system stability.

Testing:
- Successfully tested on QEMU-8.1.2.
- Note: please apply the changes from apache/nuttx-apps#1962.

Signed-off-by: Masayuki Ishikawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants